From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144Ab2GWKDt (ORCPT ); Mon, 23 Jul 2012 06:03:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11189 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743Ab2GWKDq (ORCPT ); Mon, 23 Jul 2012 06:03:46 -0400 Message-ID: <500D2162.8010209@redhat.com> Date: Mon, 23 Jul 2012 13:03:14 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Raghavendra K T CC: "H. Peter Anvin" , Thomas Gleixner , Marcelo Tosatti , Ingo Molnar , Rik van Riel , Srikar , S390 , Carsten Otte , Christian Borntraeger , KVM , chegu vinod , "Andrew M. Theurer" , LKML , X86 , Gleb Natapov , linux390@de.ibm.com, Srivatsa Vaddagiri , Joerg Roedel Subject: Re: [PATCH RFC V5 0/3] kvm: Improving directed yield in PLE handler References: <20120718133717.5321.71347.sendpatchset@codeblue.in.ibm.com> In-Reply-To: <20120718133717.5321.71347.sendpatchset@codeblue.in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/2012 04:37 PM, Raghavendra K T wrote: > Currently Pause Loop Exit (PLE) handler is doing directed yield to a > random vcpu on pl-exit. We already have filtering while choosing > the candidate to yield_to. This change adds more checks while choosing > a candidate to yield_to. > > On a large vcpu guests, there is a high probability of > yielding to the same vcpu who had recently done a pause-loop exit. > Such a yield can lead to the vcpu spinning again. > > The patchset keeps track of the pause loop exit and gives chance to a > vcpu which has: > > (a) Not done pause loop exit at all (probably he is preempted lock-holder) > > (b) vcpu skipped in last iteration because it did pause loop exit, and > probably has become eligible now (next eligible lock holder) > > This concept also helps in cpu relax interception cases which use same handler. > Thanks, applied to 'queue'. -- error compiling committee.c: too many arguments to function