public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Denis Turischev <denis@compulab.co.il>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.
Date: Mon, 23 Jul 2012 14:46:32 +0300	[thread overview]
Message-ID: <500D3998.7010705@compulab.co.il> (raw)
In-Reply-To: <20120718165916.GA30828@xanatos>

Intense-PC is Compulab's mini-desktop with Intel Panther Point
chipset.

Unconditional switchover to xHCI provided by function
usb_enable_xhci_ports() leads to surprising results, after shutdown
system powered-on again after a few seconds. On Windows power
related problems were not observed. Switching back to EHCI solves
the problem.

The patch switches usb ports back to EHCI during xhci shutdown
for Intense-PC.

Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
 drivers/usb/host/xhci.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index a979cd0..541efaa 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -26,6 +26,8 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/slab.h>
+#include <linux/dmi.h>
+#include "pci-quirks.h"

 #include "xhci.h"

@@ -656,8 +658,20 @@ void xhci_stop(struct usb_hcd *hcd)
  */
 void xhci_shutdown(struct usb_hcd *hcd)
 {
+	struct pci_dev *pdev;
+	const char *brd_name;
 	struct xhci_hcd *xhci = hcd_to_xhci(hcd);

+	pdev = to_pci_dev(hcd->self.controller);
+
+	if (usb_is_intel_switchable_xhci(pdev)) {
+		brd_name = dmi_get_system_info(DMI_BOARD_NAME);
+
+		/* quirk for Compulab's Intense-PC board */
+		if (brd_name && strstr(brd_name, "Intense-PC"))
+			usb_disable_xhci_ports(pdev);
+	}
+
 	spin_lock_irq(&xhci->lock);
 	xhci_halt(xhci);
 	spin_unlock_irq(&xhci->lock);
-- 
1.7.9.5


  parent reply	other threads:[~2012-07-23 11:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16 16:46 [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC Denis Turischev
2012-07-17  4:54 ` Sarah Sharp
2012-07-18  6:57   ` Denis Turischev
2012-07-18 16:59     ` Sarah Sharp
2012-07-23 11:46       ` [PATCH 1/2] xhci: provide usb_disable_xhci_ports function for Intel chipsets Denis Turischev
2012-07-23 14:45         ` Sergei Shtylyov
2012-07-23 15:59           ` [PATCH 1/2 v2] " Denis Turischev
2012-07-23 11:46       ` Denis Turischev [this message]
2012-07-23 17:44         ` [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC Sarah Sharp
2012-07-24  8:50           ` Denis Turischev
2012-07-24 19:46             ` Sarah Sharp
2012-07-30 22:34               ` Sarah Sharp
2012-07-31  4:49                 ` Oliver Neukum
2012-07-31 17:06                   ` Sarah Sharp
2012-07-31 18:39                     ` Sarah Sharp
2012-07-31 10:42                 ` Denis Turischev
2012-08-07 17:35         ` Sarah Sharp
2012-08-07 17:39           ` [RFT] xhci: Switch PPT ports to EHCI on shutdown Sarah Sharp
2012-08-09 14:31             ` Denis Turischev
2012-08-23  4:30             ` Robert Hancock
2012-07-17 12:20 ` [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500D3998.7010705@compulab.co.il \
    --to=denis@compulab.co.il \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox