public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>
Subject: Bug in UDF, setting larger file size when data in ICB
Date: Mon, 23 Jul 2012 16:19:35 +0100	[thread overview]
Message-ID: <500D6B87.7070700@mev.co.uk> (raw)

Hi folks,

in fs/udf/inode.c, udf_setsize(), if the new size is larger than the old 
size and the old data is in the ICB and the new size still fits in the 
ICB (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB and iinfo->i_lenAlloc 
= newsize), udf_extend_file() is called which promptly calls BUG() 
because it does not like this i_alloc_type value.

I think the simplest fix would be to add a 'goto' after the assignment 
to iinfo->i_lenAlloc, bypassing the call to udf_extend_file().

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

             reply	other threads:[~2012-07-23 15:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 15:19 Ian Abbott [this message]
2012-07-23 16:43 ` Bug in UDF, setting larger file size when data in ICB Ian Abbott
2012-08-14 22:22   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500D6B87.7070700@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox