From: Daniel Mack <zonque@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sven Neumann <s.neumann@raumfeld.com>,
Olof Johansson <olof@lixom.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN
Date: Mon, 23 Jul 2012 19:58:31 +0200 [thread overview]
Message-ID: <500D90C7.9000903@gmail.com> (raw)
In-Reply-To: <20120723165120.GB26577@core.coreip.homeip.net>
On 23.07.2012 18:51, Dmitry Torokhov wrote:
> On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote:
>> Ok, finally I found some time. In general, the patch works fine. The
>> only detail I had to amend was the irqflags, which were changed from
>> IRQF_TRIGGER_RISING/IRQF_TRIGGER_FALLING to
>> IRQF_TRIGGER_HIGH/IRQF_TRIGGER_LOW, which doesn't work as the PXA can't
>> deal with level-based IRQs. Changing this back to RISING/FALLING makes
>> the driver work again.
>
> Hmm, but that would mean we need to restore reading the data in open()
> to make sure we re-arm IRQ in case somebody touched the screen before it
> was opened by userspace...
Hmm, right, that was the reason why I put it there in the first place.
Thanks for the heads-up. Would you do it? Want me to?
Daniel
next prev parent reply other threads:[~2012-07-23 17:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 5:40 [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN Olof Johansson
2012-04-07 7:02 ` Dmitry Torokhov
2012-04-07 18:38 ` Sven Neumann
2012-04-07 20:32 ` Olof Johansson
2012-04-07 21:04 ` Joachim Eastwood
2012-04-09 2:28 ` Haojian Zhuang
2012-04-10 10:10 ` Russell King - ARM Linux
2012-04-10 16:01 ` Dmitry Torokhov
2012-05-03 4:36 ` Dmitry Torokhov
2012-07-13 7:01 ` Dmitry Torokhov
2012-07-15 18:21 ` Daniel Mack
2012-07-17 12:59 ` Daniel Mack
2012-07-19 15:36 ` Daniel Mack
2012-07-23 16:51 ` Dmitry Torokhov
2012-07-23 17:58 ` Daniel Mack [this message]
2012-07-24 18:01 ` Emulating level IRQs (was: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN) Daniel Mack
2012-07-24 18:58 ` Mark Brown
2012-08-05 16:22 ` Emulating level IRQs Daniel Mack
2012-08-05 16:56 ` Haojian Zhuang
2012-08-05 17:56 ` Daniel Mack
2012-08-06 1:45 ` Eric Miao
2012-08-06 16:36 ` Mark Brown
2012-08-07 15:19 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D90C7.9000903@gmail.com \
--to=zonque@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=s.neumann@raumfeld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).