From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: w.sang@pengutronix.de, khali@linux-fr.org, ben-linux@fluff.org,
swarren@nvidia.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq
Date: Mon, 23 Jul 2012 12:24:38 -0600 [thread overview]
Message-ID: <500D96E6.4060507@wwwdotorg.org> (raw)
In-Reply-To: <1341919244-23327-6-git-send-email-ldewangan@nvidia.com>
On 07/10/2012 05:20 AM, Laxman Dewangan wrote:
> To provide the late suspend and early resume for i2c
> driver, convert the suspend/resume as
> suspend-> suspend_noirq
> resume -> resume_noirq
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Why do we need this change?
IIRC, I proposed it before solely to solve some suspend/resume ordering
issues, and Colin Cross NAKd it. These days, deferred probe should make
this change unnecessary.
Unless there's a really good reason for this change, I'd tend to request
reverting it.
next prev parent reply other threads:[~2012-07-23 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 11:20 [PATCH 0/5] i2c: tegra: Code cleanups and suspend/resume related changes Laxman Dewangan
2012-07-10 11:20 ` [PATCH 1/5] i2c: tegra: remove unused member variable Laxman Dewangan
2012-07-10 11:33 ` Shubhrajyoti Datta
2012-07-10 11:20 ` [PATCH 2/5] i2c: tegra: use clk_disable_unprepare in place of clk_disable Laxman Dewangan
2012-07-12 9:52 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 3/5] i2c: tegra: use of_match_ptr() for match_table initialization Laxman Dewangan
2012-07-12 9:52 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 4/5] i2c: tegra: Use struct dev_pm_ops for power management Laxman Dewangan
2012-07-12 9:53 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq Laxman Dewangan
2012-07-12 10:35 ` Wolfram Sang
2012-07-12 10:30 ` Laxman Dewangan
2012-07-12 11:58 ` Wolfram Sang
2012-07-12 11:53 ` Laxman Dewangan
2012-07-23 18:24 ` Stephen Warren [this message]
2012-07-24 9:13 ` Peter De Schrijver
2012-07-24 12:52 ` Mark Brown
2012-07-24 15:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D96E6.4060507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ben-linux@fluff.org \
--cc=ccross@android.com \
--cc=khali@linux-fr.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox