From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <lenb@kernel.org>, <linux-acpi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] acpi : create sun sysfs file in container device
Date: Tue, 24 Jul 2012 12:03:22 +0900 [thread overview]
Message-ID: <500E107A.7030907@jp.fujitsu.com> (raw)
There is no comment on the patch about a month. But I want to merge the patch
into linux-3.6. So I resend it.
---
Even if container device has _SUN method, the method is ignored. So we cannot
know slot-unique ID number of the container device. The patch creates "sun"
file in sysfs so that we can recognize it.
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/acpi/container.c | 36 +++++++++++++++++++++++++++++++++---
1 file changed, 33 insertions(+), 3 deletions(-)
Index: linux-3.5-rc1/drivers/acpi/container.c
===================================================================
--- linux-3.5-rc1.orig/drivers/acpi/container.c 2012-06-14 15:35:31.045500166 +0900
+++ linux-3.5-rc1/drivers/acpi/container.c 2012-06-14 16:40:13.010405144 +0900
@@ -32,6 +32,7 @@
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/acpi.h>
+#include <linux/device.h>
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
#include <acpi/container.h>
@@ -93,10 +94,30 @@ static int is_device_present(acpi_handle
}
/*******************************************************************/
+
+static ssize_t acpi_device_sun_show(struct device *dev,
+ struct device_attribute *attr, char *buf) {
+ struct acpi_device *device = to_acpi_device(dev);
+ acpi_status status;
+ unsigned long long sun;
+
+ status = acpi_evaluate_integer(device->handle, "_SUN", NULL, &sun);
+ if (ACPI_FAILURE(status))
+ return 0;
+
+ return sprintf(buf, "%llu\n", sun);
+}
+
+static DEVICE_ATTR(sun, 0444, acpi_device_sun_show, NULL);
+
+/*******************************************************************/
+
static int acpi_container_add(struct acpi_device *device)
{
struct acpi_container *container;
-
+ acpi_status status;
+ acpi_handle temp;
+ int result = 0;
if (!device) {
printk(KERN_ERR PREFIX "device is NULL\n");
@@ -115,13 +136,22 @@ static int acpi_container_add(struct acp
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device <%s> bid <%s>\n",
acpi_device_name(device), acpi_device_bid(device)));
- return 0;
+ status = acpi_get_handle(device->handle, "_SUN", &temp);
+ if (ACPI_SUCCESS(status))
+ result = device_create_file(&device->dev, &dev_attr_sun);
+
+ return result;
}
static int acpi_container_remove(struct acpi_device *device, int type)
{
- acpi_status status = AE_OK;
+ acpi_status status;
struct acpi_container *pc = NULL;
+ acpi_handle temp;
+
+ status = acpi_get_handle(device->handle, "_SUN", &temp);
+ if (ACPI_SUCCESS(status))
+ device_remove_file(&device->dev, &dev_attr_sun);
pc = acpi_driver_data(device);
kfree(pc);
next reply other threads:[~2012-07-24 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 3:03 Yasuaki Ishimatsu [this message]
[not found] <500F6739.8090506@jp.fujitsu.com>
2012-07-25 18:24 ` [PATCH] acpi : create sun sysfs file in container device Toshi Kani
-- strict thread matches above, loose matches on Subject: below --
2012-06-14 7:46 Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E107A.7030907@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox