From: Jeff Law <law@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Boyer <jwboyer@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition
Date: Tue, 24 Jul 2012 13:26:39 -0600 [thread overview]
Message-ID: <500EF6EF.4080708@redhat.com> (raw)
In-Reply-To: <CA+55aFwvidWyBK5+U_4r5uibSkk4A-1jbnY-i9BtRgbx=Odo7w@mail.gmail.com>
On 07/24/12 13:24, Linus Torvalds wrote:
> On Tue, Jul 24, 2012 at 12:15 PM, Jeff Law <law@redhat.com> wrote:
>>
>> Please refer to the original discussion where they did evaluate the cost of
>> this change and tested that the final change made no difference to the
>> generated code.
>
> Umm. That bugzilla entry seems to be talking about a *sane* change, namely
>
> - ({ unsigned long int __d = (d); \
> + ({ unsigned long int __d = (unsigned long int) (d); \
>
> in __FD_ELT(), which is totally different from the one Josh talks about.
Right. Josh's change is necessary to prevent warnings from folks
(incorrectly) using posix_types.h instead of select.h after the change
in that BZ was made. That's why I originally stated that, arguably,
posix_types.h really should go away or just use the definitions provided
by glibc.
Jeff
next prev parent reply other threads:[~2012-07-24 19:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 18:12 [PATCH] posix_types.h: make __NFDBITS match glibc definition Josh Boyer
2012-07-24 18:20 ` Linus Torvalds
2012-07-24 18:24 ` Josh Boyer
2012-07-24 18:32 ` [PATCH v2] posix_types.h: make __NFDBITS compatible with " Josh Boyer
2012-07-24 18:46 ` Linus Torvalds
2012-07-24 19:03 ` Josh Boyer
2012-07-24 19:09 ` Linus Torvalds
2012-07-24 19:15 ` Jeff Law
2012-07-24 19:24 ` Linus Torvalds
2012-07-24 19:26 ` Jeff Law [this message]
2012-07-24 19:43 ` Josh Boyer
2012-07-24 19:55 ` Linus Torvalds
2012-07-24 20:10 ` Josh Boyer
2012-07-24 20:13 ` Linus Torvalds
2012-07-24 20:02 ` Andreas Schwab
2012-07-24 19:43 ` Linus Torvalds
2012-07-24 20:01 ` Jeff Law
2012-07-24 19:19 ` [PATCH] posix_types.h: make __NFDBITS match " Jeff Law
2012-07-24 19:37 ` Linus Torvalds
2012-07-24 19:39 ` Linus Torvalds
2012-07-24 19:41 ` Josh Boyer
2012-07-24 19:59 ` Linus Torvalds
2012-07-24 20:11 ` Linus Torvalds
2012-07-24 20:52 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500EF6EF.4080708@redhat.com \
--to=law@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).