From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753819Ab2GXT0m (ORCPT ); Tue, 24 Jul 2012 15:26:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28697 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949Ab2GXT0k (ORCPT ); Tue, 24 Jul 2012 15:26:40 -0400 Message-ID: <500EF6EF.4080708@redhat.com> Date: Tue, 24 Jul 2012 13:26:39 -0600 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Linus Torvalds CC: Josh Boyer , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition References: <20120724181209.GA10534@zod.bos.redhat.com> <20120724182409.GB10534@zod.bos.redhat.com> <20120724183230.GC10534@zod.bos.redhat.com> <20120724190302.GE10534@zod.bos.redhat.com> <500EF43C.3060200@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/12 13:24, Linus Torvalds wrote: > On Tue, Jul 24, 2012 at 12:15 PM, Jeff Law wrote: >> >> Please refer to the original discussion where they did evaluate the cost of >> this change and tested that the final change made no difference to the >> generated code. > > Umm. That bugzilla entry seems to be talking about a *sane* change, namely > > - ({ unsigned long int __d = (d); \ > + ({ unsigned long int __d = (unsigned long int) (d); \ > > in __FD_ELT(), which is totally different from the one Josh talks about. Right. Josh's change is necessary to prevent warnings from folks (incorrectly) using posix_types.h instead of select.h after the change in that BZ was made. That's why I originally stated that, arguably, posix_types.h really should go away or just use the definitions provided by glibc. Jeff