From: Chanwoo Choi <cw00.choi@samsung.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Lockwood <lockwood@android.com>
Subject: Re: [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one
Date: Wed, 25 Jul 2012 15:19:05 +0900 [thread overview]
Message-ID: <500F8FD9.1080601@samsung.com> (raw)
In-Reply-To: <1343093217.7556.1.camel@phoenix>
On 07/24/2012 10:26 AM, Axel Lin wrote:
> commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one"
> missed the replacement for devm_gpio_request_one. fix it.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/extcon/extcon_gpio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe3db45..3cc152e 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
> if (ret < 0)
> return ret;
>
> - ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
> + ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
> + pdev->name);
> if (ret < 0)
> goto err;
>
It is right.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you,
Chanwoo Choi
prev parent reply other threads:[~2012-07-25 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 1:26 [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one Axel Lin
2012-07-25 6:19 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F8FD9.1080601@samsung.com \
--to=cw00.choi@samsung.com \
--cc=axel.lin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lockwood@android.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox