* [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one
@ 2012-07-24 1:26 Axel Lin
2012-07-25 6:19 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-07-24 1:26 UTC (permalink / raw)
To: linux-kernel
Cc: MyungJoo Ham, Greg Kroah-Hartman, Mike Lockwood, Chanwoo Choi
commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one"
missed the replacement for devm_gpio_request_one. fix it.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/extcon/extcon_gpio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
index fe3db45..3cc152e 100644
--- a/drivers/extcon/extcon_gpio.c
+++ b/drivers/extcon/extcon_gpio.c
@@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
+ ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
+ pdev->name);
if (ret < 0)
goto err;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one
2012-07-24 1:26 [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one Axel Lin
@ 2012-07-25 6:19 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2012-07-25 6:19 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, MyungJoo Ham, Greg Kroah-Hartman, Mike Lockwood
On 07/24/2012 10:26 AM, Axel Lin wrote:
> commit 01eaf24 "extcon: Convert extcon_gpio to devm_gpio_request_one"
> missed the replacement for devm_gpio_request_one. fix it.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/extcon/extcon_gpio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe3db45..3cc152e 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -107,7 +107,8 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
> if (ret < 0)
> return ret;
>
> - ret = gpio_request_one(extcon_data->gpio, GPIOF_DIR_IN, pdev->name);
> + ret = devm_gpio_request_one(&pdev->dev, extcon_data->gpio, GPIOF_DIR_IN,
> + pdev->name);
> if (ret < 0)
> goto err;
>
It is right.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-25 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 1:26 [PATCH] extcon: extcon_gpio: Replace gpio_request_one by devm_gpio_request_one Axel Lin
2012-07-25 6:19 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox