From: Paolo Bonzini <pbonzini@redhat.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Wang Sen <senwang@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, JBottomley@parallels.com,
stefanha@linux.vnet.ibm.com, mc@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list
Date: Wed, 25 Jul 2012 14:50:09 +0200 [thread overview]
Message-ID: <500FEB81.4020008@redhat.com> (raw)
In-Reply-To: <500FEAC7.2050803@panasas.com>
Il 25/07/2012 14:47, Boaz Harrosh ha scritto:
>
> NACK-by: Boaz Harrosh
>
>
> Apart from the HighMem pages problem, where in previous sg_set_buf()
> code was the marker copied? It was not because it is not needed because
> the allocation of sg took care of that. For example in 64bit the is no
> bugs, right?
>
> If there was a destination sg_list termination bug, it should be fixed
> as a separate patch from this "HighMem pages problem". But I bet if
> you inspect the code carefully there isn't such a bug.
Hmm, we're talking past each other. Let's sort it out in the v1 thread.
Sen, please hold up the patch for a moment.
Paolo
prev parent reply other threads:[~2012-07-25 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 12:13 [PATCH v2] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list Wang Sen
2012-07-25 12:21 ` Ben Hutchings
2012-07-26 9:20 ` Wang Sen
2012-07-25 12:34 ` Paolo Bonzini
2012-07-25 12:47 ` Boaz Harrosh
2012-07-25 12:50 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FEB81.4020008@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@parallels.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mc@linux.vnet.ibm.com \
--cc=senwang@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox