From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932750Ab2GYRBC (ORCPT ); Wed, 25 Jul 2012 13:01:02 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:62543 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755833Ab2GYRA7 (ORCPT ); Wed, 25 Jul 2012 13:00:59 -0400 Message-ID: <501025EC.6010600@mvista.com> Date: Wed, 25 Jul 2012 20:59:24 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "Mohammed, Afzal" CC: "Hilman, Kevin" , "a.zummo@towertech.it" , "davinci-linux-open-source@linux.davincidsp.com" , "linux@arm.linux.org.uk" , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" , "tony@atomide.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "grant.likely@secretlab.ca" , "rob@landley.net" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 6/6] arm/dts: am33xx rtc node References: <500FD698.30906@mvista.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 07/25/2012 06:09 PM, Mohammed, Afzal wrote: >>> + rtc@44e3e000 { >> Address postfix in the node name without "reg" property? > As per [1], "The unit-address is included if the node describes > a device with an address". Which in this case it doesn't. > Here even though reg property is not present, as via hwmod > (see below) it is getting address, isn't it better to have it I think not. >>> + compatible = "ti,da830-rtc"; >>> + ti,hwmods = "rtc"; WBR, Sergei