From: Paolo Bonzini <pbonzini@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number
Date: Thu, 26 Jul 2012 11:04:32 +0200 [thread overview]
Message-ID: <50110820.4040403@redhat.com> (raw)
In-Reply-To: <1343292731.3115.17.camel@dabdike>
Il 26/07/2012 10:52, James Bottomley ha scritto:
>> > +static unsigned int virtscsi_get_lun(u8 *lun_bytes)
>> > +{
>> > + unsigned int lun = (lun_bytes[2] << 8) | lun_bytes[3];
>> > + return lun & 16383;
>> > +}
>> > +
> Why are you rolling your own incomplete version of scsilun_to_int here?
Because scsilun_to_int does not do the AND, so it would have exactly the
same bug I'm fixing.
Paolo
next prev parent reply other threads:[~2012-07-26 9:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 16:05 [PATCH 0/2] virtio-scsi event changes for 3.6 Paolo Bonzini
2012-07-16 16:05 ` [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number Paolo Bonzini
2012-07-26 8:52 ` James Bottomley
2012-07-26 9:04 ` Paolo Bonzini [this message]
2012-07-26 9:21 ` James Bottomley
2012-07-26 9:27 ` Paolo Bonzini
2012-07-26 9:41 ` James Bottomley
2012-07-26 9:58 ` Paolo Bonzini
2012-07-26 10:17 ` Bart Van Assche
2012-07-26 10:33 ` James Bottomley
2012-07-26 10:43 ` Paolo Bonzini
2012-07-26 11:31 ` James Bottomley
2012-07-16 16:05 ` [PATCH 2/2] virtio-scsi: support online resizing of disks Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50110820.4040403@redhat.com \
--to=pbonzini@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox