From: Paolo Bonzini <pbonzini@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number
Date: Thu, 26 Jul 2012 11:27:40 +0200 [thread overview]
Message-ID: <50110D8C.8060802@redhat.com> (raw)
In-Reply-To: <1343294472.3115.22.camel@dabdike>
Il 26/07/2012 11:21, James Bottomley ha scritto:
>> > Because scsilun_to_int does not do the AND, so it would have exactly the
>> > same bug I'm fixing.
> It's not a bug ... it's the encoding. All the other devices use this
> too. Ideally we should have switched to 64 bit lun numbers for the
> encoding to be exact, but nothing so far has gone over 32 bits. If we
> don't encode the Address method as part of the lun number, we don't get
> the reverse transform right and the addressing often fails.
But virtio-scsi gets it right even if you use method=0 and method=1
interchangeably.
ibmvscsi (see function lun_from_dev) does something similar to
virtio-scsi, except here I need both directions.
> That does mean that arrays that use address method=1 in REPORT LUNS have
> their lun numbers start at 16384.
That is ugly. I can see how it may be needed on buggy hardware, but
here we know it's not.
Paolo
next prev parent reply other threads:[~2012-07-26 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 16:05 [PATCH 0/2] virtio-scsi event changes for 3.6 Paolo Bonzini
2012-07-16 16:05 ` [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number Paolo Bonzini
2012-07-26 8:52 ` James Bottomley
2012-07-26 9:04 ` Paolo Bonzini
2012-07-26 9:21 ` James Bottomley
2012-07-26 9:27 ` Paolo Bonzini [this message]
2012-07-26 9:41 ` James Bottomley
2012-07-26 9:58 ` Paolo Bonzini
2012-07-26 10:17 ` Bart Van Assche
2012-07-26 10:33 ` James Bottomley
2012-07-26 10:43 ` Paolo Bonzini
2012-07-26 11:31 ` James Bottomley
2012-07-16 16:05 ` [PATCH 2/2] virtio-scsi: support online resizing of disks Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50110D8C.8060802@redhat.com \
--to=pbonzini@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox