public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Daniel Wisehart <daniel.wisehart@eladian.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/patch-kernel fix
Date: Thu, 26 Jul 2012 12:10:44 +0200	[thread overview]
Message-ID: <501117A4.60704@suse.cz> (raw)
In-Reply-To: <9b2de540-7ff6-4853-8331-5b9f0d28051c@mail.eladian.com>

On 19.7.2012 23:49, Daniel Wisehart wrote:
> diff --git a/scripts/patch-kernel b/scripts/patch-kernel
> index d000ea3..a7672eb 100755
> --- a/scripts/patch-kernel
> +++ b/scripts/patch-kernel
> @@ -226,7 +226,7 @@ fi
>  
>  # This all assumes a 2.6.x[.y] kernel tree.
>  # Don't allow backwards/reverse patching.
> -if [ $STOPSUBLEVEL -lt $SUBLEVEL ]; then
> +if [ "$STOPSUBLEVEL"0 -lt "$SUBLEVEL"0 ]; then

Hi Daniel,

While this is correct, it is not obvious at first sight why you need to
multiply the numbers by 10. Or at least it was not obvious to me :).
Could you use the more common idiom 0$NUMBER? The shell interprets the
numbers as decimal, so it's works fine.

Michal

  reply	other threads:[~2012-07-26 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cf445a75-137c-4689-aa34-6c89cbd92b7b@mail.eladian.com>
2012-07-19 21:49 ` [PATCH] scripts/patch-kernel fix Daniel Wisehart
2012-07-26 10:10   ` Michal Marek [this message]
2012-08-17 21:26     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501117A4.60704@suse.cz \
    --to=mmarek@suse.cz \
    --cc=daniel.wisehart@eladian.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox