From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137Ab2GZKnW (ORCPT ); Thu, 26 Jul 2012 06:43:22 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:43510 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868Ab2GZKnU (ORCPT ); Thu, 26 Jul 2012 06:43:20 -0400 Message-ID: <50111F36.6000407@parallels.com> Date: Thu, 26 Jul 2012 14:43:02 +0400 From: Pavel Emelyanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Cyrill Gorcunov CC: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Al Viro , Alexey Dobriyan , Andrew Morton , James Bottomley , Matthew Helsley Subject: Re: [patch 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file References: <20120725094718.089879534@openvz.org> <20120725095024.760705388@openvz.org> In-Reply-To: <20120725095024.760705388@openvz.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/25/2012 01:47 PM, Cyrill Gorcunov wrote: > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which > is needed to extend seq operations and plug in auxiliary fdinfo provides > from subsystems like eventfd/eventpoll/fsnotify. > > Note the proc_fd_link no longer call for proc_fd_info, simply because > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open() > prototype), moreover in further patches I need to provide two seq_fdinfo_open > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this > symbol. All in one -- this will look more messy then. This is something I'm really not happy with :( After the set applied we will have one former proc_fd_info being splitted into 3 (three!) functions doing the same (with flavors). For me it's better to fix this, otherwise conversion to seq-file looks OK. > Signed-off-by: Cyrill Gorcunov > CC: Al Viro > CC: Alexey Dobriyan > CC: Andrew Morton > CC: Pavel Emelyanov > CC: James Bottomley > --- > fs/proc/fd.c | 133 +++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 85 insertions(+), 48 deletions(-)