linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Love, Robert W" <robert.w.love@intel.com>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@open-fcoe.org" <devel@open-fcoe.org>,
	Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit()
Date: Thu, 26 Jul 2012 14:05:08 +0000	[thread overview]
Message-ID: <50114E80.70303@intel.com> (raw)
In-Reply-To: <1343271764-17501-1-git-send-email-handai.szj@taobao.com>

On 7/25/2012 8:02 PM, Sha Zhengju wrote:

From: Sha Zhengju <handai.szj@taobao.com><mailto:handai.szj@taobao.com>

While testing linux mainline v3.5, it comes out the following warning:

WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function
init_module() to the function .exit.text:fcoe_transport_exit()
The function __init init_module() references a function __exit fcoe_transport_exit().
This is often seen when error handling in the init function uses functionality in the exit path.
The fix is often to remove the __exit annotation of fcoe_transport_exit() so it may be used outside an exit section.



Hi Sha,

    Thanks for the patch. I have seen this same change a few times. The warning has existed for the entirety of the 3.5 development cycle. It's currently in scsi.git/for-next. Take a look at this tread from linux-scsi for the discussion about it.

http://marc.info/?l=linux-scsi&m=134103414011479&w=2

Thanks, //Rob

      reply	other threads:[~2012-07-26 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26  3:02 [PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit() Sha Zhengju
2012-07-26 14:05 ` Love, Robert W [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50114E80.70303@intel.com \
    --to=robert.w.love@intel.com \
    --cc=devel@open-fcoe.org \
    --cc=handai.szj@gmail.com \
    --cc=handai.szj@taobao.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).