[PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit()

[PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit()

[Sha Zhengju]

From: Sha Zhengju <handai.szj@taobao.com>

While testing linux mainline v3.5, it comes out the following warning:

WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function
init_module() to the function .exit.text:fcoe_transport_exit()
The function __init init_module() references a function __exit fcoe_transport_exit().
This is often seen when error handling in the init function uses functionality in the exit path.
The fix is often to remove the __exit annotation of fcoe_transport_exit() so it may be used outside an exit section.


Signed-off-by: Sha Zhengju <handai.szj@taobao.com>
Cc: robert.w.love@intel.com
---
 drivers/scsi/fcoe/fcoe_transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index b46f43d..71cc909 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -502,7 +502,7 @@ static int __init fcoe_transport_init(void)
 	return 0;
 }
 
-static int __exit fcoe_transport_exit(void)
+static int fcoe_transport_exit(void)
 {
 	struct fcoe_transport *ft;
 
-- 
1.7.1

Re: [PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit()

[Love, Robert W]

On 7/25/2012 8:02 PM, Sha Zhengju wrote:

From: Sha Zhengju <handai.szj@taobao.com><mailto:handai.szj@taobao.com>

While testing linux mainline v3.5, it comes out the following warning:

WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function
init_module() to the function .exit.text:fcoe_transport_exit()
The function __init init_module() references a function __exit fcoe_transport_exit().
This is often seen when error handling in the init function uses functionality in the exit path.
The fix is often to remove the __exit annotation of fcoe_transport_exit() so it may be used outside an exit section.



Hi Sha,

    Thanks for the patch. I have seen this same change a few times. The warning has existed for the entirety of the 3.5 development cycle. It's currently in scsi.git/for-next. Take a look at this tread from linux-scsi for the discussion about it.

http://marc.info/?l=linux-scsi&m=134103414011479&w=2

Thanks, //Rob