From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337Ab2GZOFk (ORCPT ); Thu, 26 Jul 2012 10:05:40 -0400 Received: from mga09.intel.com ([134.134.136.24]:56092 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619Ab2GZOFh convert rfc822-to-8bit (ORCPT ); Thu, 26 Jul 2012 10:05:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="177842225" From: "Love, Robert W" To: Sha Zhengju CC: "torvalds@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "devel@open-fcoe.org" , Sha Zhengju Subject: Re: [PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit() Thread-Topic: [PATCH] mainline 3.5, fcoe: remove the __exit annotation of fcoe_transport_exit() Thread-Index: AQHNatsqI6bfWpza7kuufbNrvbHRFJc8Dt4A Date: Thu, 26 Jul 2012 14:05:08 +0000 Message-ID: <50114E80.70303@intel.com> References: <1343271764-17501-1-git-send-email-handai.szj@taobao.com> In-Reply-To: <1343271764-17501-1-git-send-email-handai.szj@taobao.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 x-originating-ip: [10.19.9.42] Content-Type: text/plain; charset=US-ASCII Content-ID: <6FDAFB903AD809448DB7E1CFDCFDD7C9@intel.com> Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/2012 8:02 PM, Sha Zhengju wrote: From: Sha Zhengju While testing linux mainline v3.5, it comes out the following warning: WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transport_exit() The function __init init_module() references a function __exit fcoe_transport_exit(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __exit annotation of fcoe_transport_exit() so it may be used outside an exit section. Hi Sha, Thanks for the patch. I have seen this same change a few times. The warning has existed for the entirety of the 3.5 development cycle. It's currently in scsi.git/for-next. Take a look at this tread from linux-scsi for the discussion about it. http://marc.info/?l=linux-scsi&m=134103414011479&w=2 Thanks, //Rob