[PATCH 0/2] regulator: Kconfig grammar & whitespace

[PATCH 0/2] regulator: Kconfig grammar & whitespace

[Michael Jones]

These fix grammar and whitespace.

Michael Jones (2):
  regulator: whitespace
  regulator: grammar fix in Kconfig

 drivers/regulator/Kconfig |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.7.4.1


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

[PATCH 1/2] regulator: whitespace

[Michael Jones]

Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
---
 drivers/regulator/Kconfig |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index c86b886..403503f 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -49,11 +49,11 @@ config REGULATOR_VIRTUAL_CONSUMER
 	tristate "Virtual regulator consumer support"
 	help
 	  This driver provides a virtual consumer for the voltage and
-          current regulator API which provides sysfs controls for
-          configuring the supplies requested.  This is mainly useful
-          for test purposes.
+	  current regulator API which provides sysfs controls for
+	  configuring the supplies requested.  This is mainly useful
+	  for test purposes.
 
-          If unsure, say no.
+	  If unsure, say no.
 
 config REGULATOR_USERSPACE_CONSUMER
 	tristate "Userspace regulator consumer support"
@@ -62,7 +62,7 @@ config REGULATOR_USERSPACE_CONSUMER
 	  from user space. Userspace consumer driver provides ability to
 	  control power supplies for such devices.
 
-          If unsure, say no.
+	  If unsure, say no.
 
 config REGULATOR_GPIO
 	tristate "GPIO regulator support"
@@ -218,7 +218,7 @@ config REGULATOR_LP3972
 
 config REGULATOR_PCF50633
 	tristate "NXP PCF50633 regulator driver"
-        depends on MFD_PCF50633
+	depends on MFD_PCF50633
 	help
 	 Say Y here to support the voltage regulators and convertors
 	 on PCF50633
@@ -379,7 +379,7 @@ config REGULATOR_WM8350
 	depends on MFD_WM8350
 	help
 	  This driver provides support for the voltage and current regulators
-          of the WM8350 AudioPlus PMIC.
+	  of the WM8350 AudioPlus PMIC.
 
 config REGULATOR_WM8400
 	tristate "Wolfson Microelectronics WM8400 AudioPlus PMIC"
-- 
1.7.4.1


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

[PATCH 2/2] regulator: grammar fix in Kconfig

[Michael Jones]

Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
---
 drivers/regulator/Kconfig |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 403503f..48419d1 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -32,9 +32,8 @@ config REGULATOR_DUMMY
 	help
 	  If this option is enabled then when a regulator lookup fails
 	  and the board has not specified that it has provided full
-	  constraints then the regulator core will provide an always
-	  enabled dummy regulator will be provided, allowing consumer
-	  drivers to continue.
+	  constraints, the regulator core will provide an always-
+	  enabled dummy regulator, allowing consumer drivers to continue.
 
 	  A warning will be generated when this substitution is done.
 
-- 
1.7.4.1


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

Re: [PATCH 1/2] regulator: whitespace

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Thu, Jul 26, 2012 at 04:07:23PM +0200, Michael Jones wrote:
> 
> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>

Your changelog says "whitespace" and is otherwise blank...  what is the
problem you think you are fixing here?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] regulator: grammar fix in Kconfig

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

On Thu, Jul 26, 2012 at 04:07:24PM +0200, Michael Jones wrote:

> -	  constraints then the regulator core will provide an always
> -	  enabled dummy regulator will be provided, allowing consumer
> -	  drivers to continue.
> +	  constraints, the regulator core will provide an always-
> +	  enabled dummy regulator, allowing consumer drivers to continue.

This appears to be making the grammar worse, it's just removing a "then"
and inserting, random commas which don't make, much sense.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] regulator: grammar fix in Kconfig

[Michael Jones]

On 07/26/2012 04:48 PM, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 04:07:24PM +0200, Michael Jones wrote:
>
>> -	  constraints then the regulator core will provide an always
>> -	  enabled dummy regulator will be provided, allowing consumer
>> -	  drivers to continue.
>> +	  constraints, the regulator core will provide an always-
>> +	  enabled dummy regulator, allowing consumer drivers to continue.
>
> This appears to be making the grammar worse, it's just removing a "then"
> and inserting, random commas which don't make, much sense.
>

What I was trying to fix was the double "provide" in "will provide an... 
will be provided."  I agree that the if...then... was ugly, too.

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

Re: [PATCH 1/2] regulator: whitespace

[Michael Jones]

On 07/26/2012 04:44 PM, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 04:07:23PM +0200, Michael Jones wrote:
>>
>> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
>
> Your changelog says "whitespace" and is otherwise blank...  what is the
> problem you think you are fixing here?
>

I don't see what you're seeing.

Here:
https://lkml.org/lkml/2012/7/26/255
I see the patch which replaces non-uniform spaces with tabs.

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

Re: [PATCH 1/2] regulator: whitespace

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On Thu, Jul 26, 2012 at 05:12:59PM +0200, Michael Jones wrote:
> On 07/26/2012 04:44 PM, Mark Brown wrote:

> >Your changelog says "whitespace" and is otherwise blank...  what is the
> >problem you think you are fixing here?

> I don't see what you're seeing.

I'm not seeing anything at all.  That's the problem.

> Here:
> https://lkml.org/lkml/2012/7/26/255
> I see the patch which replaces non-uniform spaces with tabs.

...and only has a one word changelog.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/2] regulator: whitespace

[Michael Jones]

On 07/26/2012 05:15 PM, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 05:12:59PM +0200, Michael Jones wrote:
>> On 07/26/2012 04:44 PM, Mark Brown wrote:
>
>>> Your changelog says "whitespace" and is otherwise blank...  what is the
>>> problem you think you are fixing here?
>
>> I don't see what you're seeing.
>
> I'm not seeing anything at all.  That's the problem.
>
>> Here:
>> https://lkml.org/lkml/2012/7/26/255
>> I see the patch which replaces non-uniform spaces with tabs.
>
> ...and only has a one word changelog.
>

Sorry, I misunderstood.  I thought you saw _only_ a one word change log, 
and not even the patch.  I think I answered your question above now, right?
Q: what is the problem you think you are fixing here?
A: some lines were indented with spaces, while most of them are indented 
with tabs.

So I suppose the changelog should have been something like:
regulator: whitespace- indent with tabs not spaces

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

Re: [PATCH 1/2] regulator: whitespace

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

On Thu, Jul 26, 2012 at 05:29:14PM +0200, Michael Jones wrote:

> So I suppose the changelog should have been something like:
> regulator: whitespace- indent with tabs not spaces

Yes.  I'll apply after the merge window.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/2] regulator: whitespace

[Mark Brown]

On Thu, Jul 26, 2012 at 04:07:23PM +0200, Michael Jones wrote:
> 
> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>

Applied, thanks.