Re: [PATCH 2/2] hw_random: add support for the TPM chip as a hardware RNG source

["H. Peter Anvin" <hpa@zytor.com>]

On 06/07/2012 11:47 AM, Kent Yoder wrote:
> This driver will make use of any available TPM chip on the system as a
> hwrng source.
>
> Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
> ---
>   drivers/char/hw_random/Kconfig   |   13 +++++++++
>   drivers/char/hw_random/Makefile  |    1 +
>   drivers/char/hw_random/tpm-rng.c |   55 ++++++++++++++++++++++++++++++++++++++
>   3 files changed, 69 insertions(+), 0 deletions(-)
>   create mode 100644 drivers/char/hw_random/tpm-rng.c
>

So I just noticed this patch being pushed.

/dev/hw_random is used by rngd, which already has support for the TPM 
directly.  However, the TPM support in rngd conflict with tcsd (from 
TrouSerS).

Does this driver solve the coexistence problem?  If so, this is a Very 
Good Thing and should be accepted (and the TPM support in rngd 
deprecated/removed.)

If it does *not* solve the coexistence problem, then it just prevents a 
user space solution and the patch really should be rejected.

It would be great to get that clarified as soon as possible.

Thanks,

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.