From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025Ab2GZWMw (ORCPT ); Thu, 26 Jul 2012 18:12:52 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43140 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329Ab2GZWMv (ORCPT ); Thu, 26 Jul 2012 18:12:51 -0400 Message-ID: <5011C0C3.4090009@zytor.com> Date: Thu, 26 Jul 2012 15:12:19 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Kent Yoder CC: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, m.selhorst@sirrix.com, safford@us.ibm.com Subject: Re: [PATCH 1/2] tpm: Move tpm_get_random api into the TPM device driver References: <1339094567.21398.2.camel@key-ThinkPad-W510> <1339094834.21398.4.camel@key-ThinkPad-W510> In-Reply-To: <1339094834.21398.4.camel@key-ThinkPad-W510> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2012 11:47 AM, Kent Yoder wrote: > Move the tpm_get_random api from the trusted keys code into the TPM > device driver itself so that other callers can make use of it. Also, > change the api slightly so that the number of bytes read is returned in > the call, since the TPM command can potentially return fewer bytes than > requested. > > Signed-off-by: Kent Yoder > +int tpm_get_random(u32 chip_num, u8 *out, size_t *max) /* ... */ > case Opt_new: > - ret = my_get_random(payload->key, payload->key_len); > + ret = tpm_get_random(TPM_ANY_NUM, payload->key, > + &payload->key_len); payload->key_len is unsigned int, not size_t; this causes an overwrite of blob_len on 64-bit platforms. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.