From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbaEWPgO (ORCPT ); Fri, 23 May 2014 11:36:14 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56038 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaEWPgN (ORCPT ); Fri, 23 May 2014 11:36:13 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Daniel Thompson , Russell King , Paul Bolle , linaro-kernel@lists.linaro.org, patches@linaro.org, spear-devel@list.st.com, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Date: Fri, 23 May 2014 17:35:34 +0200 Message-ID: <5013253.K6sZTxep7b@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1400857819-7975-4-git-send-email-daniel.thompson@linaro.org> References: <1398355246-29571-1-git-send-email-daniel.thompson@linaro.org> <1400857819-7975-1-git-send-email-daniel.thompson@linaro.org> <1400857819-7975-4-git-send-email-daniel.thompson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:KN48WyE/8OUgOlwO70kTmaobWZOtUEHjDGCsyXpdzZI 8lPkNZhoAqkGO+OlVMBaQq0vqv0MN2p2BypLTt7S6oCOtI04ql f307I110DJzhPTG0BIvVAcksNho9pssTCR445vcMGoOBSIpNRF TL5VqJkHUN8iMwC2RW9sSkzVt4KjjNMgRQV+IlqNzg5+EU6AII Gbu/P2xyksd6AydZ7UW+DfRCH6QHYnTYpwCFrqKssZeUKpmIff rKlHQh673daZASBYACALVUnZF76sXLWodKY4FDqrACv+o676lr KkjSJ74Xvjm3g1Y0L1J6Dluds8riKn3QcT6QNwRtJQRkef8uEs rPXtrB8yKtrlPzThLeoA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 May 2014 16:10:17 Daniel Thompson wrote: > Only a small handful of platforms support DEBUG_LL_UART_NONE but it > lurks in the menus of every single platform config ready to break the > build. This is an especial problem for defconfigs since it is often > selected by default. > > This patch limit this choice only to platforms capable of supporting it. > > Signed-off-by: Daniel Thompson > --- > arch/arm/Kconfig.debug | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index eab8ecb..4c8d7db 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -842,7 +842,18 @@ choice > > config DEBUG_LL_UART_NONE > bool "No low-level debugging UART" > - depends on !ARCH_MULTIPLATFORM > + depends on ARCH_AT91 || \ > + ARCH_CLPS711X || \ > + ARCH_FOOTBRIDGE || \ > + ARCH_KS8695 || \ > + ARCH_NETX || \ > + ARCH_OMAP1 || \ > + ARCH_SA1100 || \ > + ARCH_S3C24XX || \ > + ARCH_S3C64XX || \ > + ARCH_S5P64X0 || \ > + ARCH_S5PC100 || \ > + ARCH_S5PV210 > help > Say Y here if your platform doesn't provide a UART option > above. This relies on your platform choosing the right UART ARCH_S3C24XX has been moved over in linux-next to use debug/s3c24xx.S. A few others will likely move soon (AT91, CLPS711x, S5PV210), as the platforms get moved to ARCH_MULTIPLATFORM. As an alternative to your patch, we could decide to move the remaining files as well. Arnd