From: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Avri Altman <avri.altman@wdc.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tony Lindgren <tony@atomide.com>, Bean Huo <beanhuo@micron.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: notasas@gmail.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [RFC v4 4/6] mmc: core: add new calls to mmc_fixup_device(sdio_card_init_methods)
Date: Mon, 08 Nov 2021 16:39:27 +0100 [thread overview]
Message-ID: <5014485.RYphtzS1IF@pc-42> (raw)
In-Reply-To: <73440c0f227778e57167dd9fedd350637a1d737a.1636103151.git.hns@goldelico.com>
On Friday 5 November 2021 10:05:49 CET H. Nikolaus Schaller wrote:
> This allows to add quirks based on device tree instead of having
> card specific code in the host ops.
>
> We call it just after where host->ops->init_card() can be optionally
> called.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
[...]
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 68edf7a615be5..cf8ee66990508 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -707,6 +707,7 @@ static int mmc_sdio_init_card(struct mmc_host *host, u32 ocr,
> */
> if (host->ops->init_card)
> host->ops->init_card(host, card);
> + mmc_fixup_device(card, sdio_card_init_methods);
sdio_read_common_cis(card) is called a bit after this line. I think it
will overwrite all the card->cis fields. This does not conflict with what
your are doing in wl1251_quirk()?
--
Jérôme Pouiller
next prev parent reply other threads:[~2021-11-08 15:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 9:05 [RFC v4 0/6] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 1/6] mmc: core: rewrite mmc_fixup_device() H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 2/6] mmc: core: allow to match the device tree to apply quirks H. Nikolaus Schaller
2021-11-05 14:27 ` Jérôme Pouiller
2021-11-06 14:31 ` H. Nikolaus Schaller
2021-11-08 15:00 ` Ulf Hansson
2021-11-08 15:34 ` Jérôme Pouiller
2021-11-08 16:01 ` H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 3/6] mmc: core: provide macro and table " H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 4/6] mmc: core: add new calls to mmc_fixup_device(sdio_card_init_methods) H. Nikolaus Schaller
2021-11-08 15:08 ` Ulf Hansson
2021-11-08 16:07 ` H. Nikolaus Schaller
2021-11-08 15:39 ` Jérôme Pouiller [this message]
2021-11-08 16:04 ` H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 5/6] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-08 15:33 ` Ulf Hansson
2021-11-08 16:08 ` H. Nikolaus Schaller
2021-11-09 10:58 ` H. Nikolaus Schaller
2021-11-09 20:01 ` Ulf Hansson
2021-11-10 16:36 ` H. Nikolaus Schaller
2021-11-10 17:03 ` Ulf Hansson
2021-11-10 17:09 ` H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 6/6] mmc: host: omap_hsmmc: revert special init for wl1251 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5014485.RYphtzS1IF@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=shawn.lin@rock-chips.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox