From: John Crispin <blogic@openwrt.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Thomas Langer <thomas.langer@lantiq.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC
Date: Mon, 30 Jul 2012 11:41:20 +0200 [thread overview]
Message-ID: <501656C0.9030609@openwrt.org> (raw)
In-Reply-To: <CACRpkdYP8PdcnS2h_-+n9ZdBmMuBPUv9so9WsUyS-X5rMz1qsQ@mail.gmail.com>
On 28/07/12 01:23, Linus Walleij wrote:
> On Tue, Jul 24, 2012 at 8:50 AM, John Crispin <blogic@openwrt.org> wrote:
>
>> Implement support for pinctrl on lantiq/falcon socs. The FALCON has 5 banks
>> of up to 32 pins.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Signed-off-by: Thomas Langer <thomas.langer@lantiq.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: devicetree-discuss@lists.ozlabs.org
>> Cc: linux-kernel@vger.kernel.org
> No big issues and looking really sweet so:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
>> --- a/arch/mips/lantiq/Kconfig
>> +++ b/arch/mips/lantiq/Kconfig
>> @@ -20,6 +20,7 @@ config SOC_XWAY
>>
>> config SOC_FALCON
>> bool "FALCON"
>> + select PINCTRL_FALCON
> I think you need to add "select PINCTRL" above "select PINCTRL_FALCON"
> for this to work.
>
> Atleast I had to do that in the past to get things working.
Hi Linus,
config LANTIQ selects PINCTRL globally for all Lantiq SoC so an
explicit select can be avoided here
Thanks for the review,
John
next prev parent reply other threads:[~2012-07-30 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 6:50 [PATCH 1/6] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support John Crispin
2012-07-24 6:50 ` [PATCH 2/6] Document: devicetree: add OF documents for lantiq xway pinctrl John Crispin
2012-07-24 6:50 ` [PATCH 3/6] OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC John Crispin
2012-07-27 23:23 ` Linus Walleij
2012-07-30 9:41 ` John Crispin [this message]
2012-07-24 6:50 ` [PATCH 4/6] Document: devicetree: add OF documents for lantiq falcon pinctrl John Crispin
2012-07-24 6:50 ` [PATCH 5/6] GPIO: MIPS: add gpio driver for flacon SoC John Crispin
2012-07-24 8:09 ` Langer Thomas (LQDE RD ST PON SW)
2012-07-24 8:20 ` John Crispin
2012-07-24 6:51 ` [PATCH 6/6] GPIO: MIPS: lantiq: fix overflow inside stp-xway driver John Crispin
2012-07-27 23:23 ` [PATCH 1/6] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501656C0.9030609@openwrt.org \
--to=blogic@openwrt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.langer@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).