From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: twl6040: Fix GPO mask
Date: Mon, 30 Jul 2012 17:17:42 +0300 [thread overview]
Message-ID: <50169786.9000109@ti.com> (raw)
In-Reply-To: <CACRpkdaOmCe05NF2d5-1xqx7UmY80LTZXJG_Lj6rnFqyk_OvHg@mail.gmail.com>
Hello Linus,
On 07/28/2012 01:45 AM, Linus Walleij wrote:
> On Wed, Jul 18, 2012 at 11:20 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>> #define TWL6040_GPO1 0x01
>> #define TWL6040_GPO2 0x02
>> -#define TWL6040_GPO3 0x03
>> +#define TWL6040_GPO3 0x04
>
> Maybe a stupid question but does these register defines really belong in that
> header file? Can't you do a separate patch moving them into the driver per
> se?
I thought about that but in this way the header file can be used as
documentation for the register bits of twl6040.
The GPIO driver do not use these defines, it is using shift to address the
correct bits in the GPO register.
Regards,
Péter
next prev parent reply other threads:[~2012-07-30 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 9:20 [PATCH 0/3] MFD/GPIO: Add twl6040 GPO driver Peter Ujfalusi
2012-07-18 9:20 ` [PATCH 1/3] mfd: twl6040: Fix GPO mask Peter Ujfalusi
2012-07-27 22:45 ` Linus Walleij
2012-07-30 14:17 ` Peter Ujfalusi [this message]
2012-07-18 9:20 ` [PATCH 2/3] mfd: twl6040: Add twl6040-gpio child Peter Ujfalusi
2012-07-27 22:50 ` Linus Walleij
2012-07-30 14:13 ` Peter Ujfalusi
2012-08-09 11:55 ` Mark Brown
2012-08-09 12:10 ` Peter Ujfalusi
2012-07-18 9:20 ` [PATCH 3/3] gpio: Add basic support for TWL6040 GPOs Peter Ujfalusi
2012-07-27 22:55 ` Linus Walleij
2012-07-27 22:43 ` [PATCH 0/3] MFD/GPIO: Add twl6040 GPO driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50169786.9000109@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox