From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164Ab2GaU5q (ORCPT ); Tue, 31 Jul 2012 16:57:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50223 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753458Ab2GaU5n (ORCPT ); Tue, 31 Jul 2012 16:57:43 -0400 Message-ID: <501846BE.6000004@redhat.com> Date: Tue, 31 Jul 2012 16:57:34 -0400 From: Larry Woodman Reply-To: lwoodman@redhat.com User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7 MIME-Version: 1.0 To: Michal Hocko CC: Mel Gorman , Rik van Riel , Hugh Dickins , Linux-MM , David Gibson , Ken Chen , Cong Wang , LKML Subject: Re: [PATCH -alternative] mm: hugetlbfs: Close race during teardown of hugetlbfs shared page tables V2 (resend) References: <20120720141108.GH9222@suse.de> <20120720143635.GE12434@tiehlicka.suse.cz> <20120720145121.GJ9222@suse.de> <50118E7F.8000609@redhat.com> <50120FA8.20409@redhat.com> <20120727102356.GD612@suse.de> <5016DC5F.7030604@redhat.com> <20120731124650.GO612@suse.de> <50181AA1.0@redhat.com> <20120731200650.GB19524@tiehlicka.suse.cz> In-Reply-To: <20120731200650.GB19524@tiehlicka.suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31/2012 04:06 PM, Michal Hocko wrote: > On Tue 31-07-12 13:49:21, Larry Woodman wrote: >> On 07/31/2012 08:46 AM, Mel Gorman wrote: >>> Fundamentally I think the problem is that we are not correctly detecting >>> that page table sharing took place during huge_pte_alloc(). This patch is >>> longer and makes an API change but if I'm right, it addresses the underlying >>> problem. The first VM_MAYSHARE patch is still necessary but would you mind >>> testing this on top please? >> Hi Mel, yes this does work just fine. It ran for hours without a panic so >> I'll Ack this one if you send it to the list. > Hi Larry, thanks for testing! I have a different patch which tries to > address this very same issue. I am not saying it is better or that it > should be merged instead of Mel's one but I would be really happy if you > could give it a try. We can discuss (dis)advantages of both approaches > later. > > Thanks! Sure, it will take me a day since I keep loosing the hardware to proproduce the problem with. I'll report back tomorrow. Larry