public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Borislav Petkov <bp@alien8.de>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: awful kconfig help texts.
Date: Wed, 01 Aug 2012 12:56:39 +0200	[thread overview]
Message-ID: <50190B67.5050108@metafoo.de> (raw)
In-Reply-To: <20120801100455.GD21303@liondog.tnic>

On 08/01/2012 12:04 PM, Borislav Petkov wrote:
> On Wed, Aug 01, 2012 at 11:38:16AM +0200, Lars-Peter Clausen wrote:
>> You don't see any drivers, because the subsystem is still young and no
>> such arch independent drivers have been added yet, but they will get
>> added in the future. The arch independent companion or PWM expander
>> chips usually interface via I2S or SPI and I would consider it quite
>> likely that you'll also find them on some embedded X86 boards. If we
>> add a arch restriction to the config item now we'd quite likely have
>> to remove it again in the next release.
> 
> Yes please.
> 
> Kconfig is overcrowded as it is now and adding yet another option which
> is irrelevant for some arches (for now, as you say) simply causes
> confusion to people with absolutely no gain.
> 
> Simply take a look at all arch/<archname>/Kconfig files and look at all
> the "select ..." statements right at the beginning of the respective
> Kconfig file.

Yes and these select statements make sense, what you suggest though doesn't,
at least from my point of view. What you want is that you don't get
presented the option to select the PWM system if there no PWM driver
available based on your other config options. But whether a PWM driver is
available or not is not a issue of which arch you are building for.

You could do that by using a construct like below, but well...

config HAS_PWM
    bool

config PWM
    bool "PWM
    depends on HAS_PWM

config PWM_CAN_BUILD_DRIVER_X
    defbool I2C
    select HAS_PWM

config PWM_DRIVER_X
    tristate "PWM chip X support"
    depends on PWM && PWM_CAN_BUILD_DRIVER_X

config PWM_CAN_BUILD_DRIVER_Y
    defbool ARCH_Y
    select HAS_PWM

config PWM_DRIVER_Y
    tristate "PWM chip Y support"
    depends on PWM && PWM_CAN_BUILD_DRIVER_Y

  reply	other threads:[~2012-08-01 10:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31 15:16 awful kconfig help texts Dave Jones
2012-07-31 17:07 ` Borislav Petkov
2012-07-31 17:26   ` Steven Rostedt
2012-07-31 17:42     ` Borislav Petkov
2012-08-01  7:47       ` Thierry Reding
2012-08-01  8:56         ` Borislav Petkov
2012-08-01  9:21           ` Lars-Peter Clausen
2012-08-01  9:26             ` Borislav Petkov
2012-08-01  9:38               ` Lars-Peter Clausen
2012-08-01 10:04                 ` Borislav Petkov
2012-08-01 10:56                   ` Lars-Peter Clausen [this message]
2012-08-01 12:46                     ` Steven Rostedt
2012-08-01 13:18                       ` Lars-Peter Clausen
2012-08-07 18:25               ` Mark Brown
2012-07-31 18:43   ` Dave Jones
2012-07-31 22:11     ` Borislav Petkov
2012-08-01  7:43   ` Thierry Reding
2012-08-01  9:28     ` Jan Engelhardt
2012-08-16  9:54   ` Thierry Reding
2012-08-16 11:10     ` Borislav Petkov
2012-08-16 12:05       ` Thierry Reding
2012-08-17  6:11         ` Thierry Reding
2012-08-17  7:00           ` Borislav Petkov
2012-08-17  7:19             ` Thierry Reding
2012-08-20  2:34           ` Cam Hutchison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50190B67.5050108@metafoo.de \
    --to=lars@metafoo.de \
    --cc=bp@alien8.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox