From: David Ahern <dsahern@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com, eranian@google.com, gorcunov@openvz.org,
tzanussi@gmail.com, mhiramat@redhat.com, robert.richter@amd.com,
fche@redhat.com, linux-kernel@vger.kernel.org,
masami.hiramatsu.pt@hitachi.com, drepper@gmail.com,
asharma@fb.com, benjamin.redelings@nescent.org
Subject: Re: [PATCH 13/13] perf, tool: Support for dwarf mode callchain on perf record
Date: Wed, 01 Aug 2012 08:26:11 -0600 [thread overview]
Message-ID: <50193C83.6050503@gmail.com> (raw)
In-Reply-To: <1343815865-5511-14-git-send-email-jolsa@redhat.com>
On 8/1/12 4:11 AM, Jiri Olsa wrote:
> +static int
> +parse_callchain_opt(const struct option *opt __used, const char *arg,
> + int unset)
> +{
> + struct perf_record *rec = (struct perf_record *)opt->value;
> + char *tok, *name, *saveptr = NULL;
> + char buf[20];
> + int ret = -1;
> +
> + /* --no-call-graph */
> + if (unset)
> + return 0;
> +
> + /* We specified default option if none is provided. */
> + BUG_ON(!arg);
> +
> + /* We need buffer that we know we can write to. */
> + snprintf(buf, 20, "%s", arg);
Isn't arg the user supplied string? What if the user messes up and
passes in 20+ characters to -g argument?
David
next prev parent reply other threads:[~2012-08-01 14:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 10:10 [PATCHv9 00/13] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-08-01 10:10 ` [PATCH 01/13] perf: Unified API to record selective sets of arch registers Jiri Olsa
2012-08-01 10:10 ` [PATCH 02/13] perf: Add ability to attach user level registers dump to sample Jiri Olsa
2012-08-01 10:10 ` [PATCH 03/13] perf, x86: Add copy_from_user_nmi_nochk for best effort copy Jiri Olsa
2012-08-01 10:10 ` [PATCH 04/13] perf: Factor __output_copy to be usable with specific copy function Jiri Olsa
2012-08-01 10:10 ` [PATCH 05/13] perf: Add perf_output_skip function to skip bytes in sample Jiri Olsa
2012-08-01 10:10 ` [PATCH 06/13] perf: Add ability to attach user stack dump to sample Jiri Olsa
2012-08-01 10:10 ` [PATCH 07/13] perf: Add attribute to filter out callchains Jiri Olsa
2012-08-02 7:38 ` Andrew Vagin
2012-08-02 8:42 ` Jiri Olsa
2012-08-01 10:11 ` [PATCH 08/13] perf, tool: Adding PERF_ATTR_SIZE_VER2 to the header swap check Jiri Olsa
2012-08-01 10:11 ` [PATCH 09/13] perf, tool: Add interface to arch registers sets Jiri Olsa
2012-08-01 10:11 ` [PATCH 10/13] perf, tool: Add libunwind dependency for dwarf cfi unwinding Jiri Olsa
2012-08-01 10:11 ` [PATCH 11/13] perf, tool: Support user regs and stack in sample parsing Jiri Olsa
2012-08-01 10:11 ` [PATCH 12/13] perf, tool: Support for dwarf cfi unwinding on post processing Jiri Olsa
2012-08-01 10:11 ` [PATCH 13/13] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
2012-08-01 14:26 ` David Ahern [this message]
2012-08-01 14:50 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2012-07-27 12:23 [PATCHv8 00/13] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-07-27 12:23 ` [PATCH 13/13] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50193C83.6050503@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=benjamin.redelings@nescent.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=drepper@gmail.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).