From: Stephen Warren <swarren@wwwdotorg.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
linux-kernel@vger.kernel.org,
Philip Avinash <avinashphilip@ti.com>
Subject: Re: [PATCH] pwm: Remove a redundant error message when devm_request_and_ioremap fails
Date: Fri, 03 Aug 2012 09:37:56 -0600 [thread overview]
Message-ID: <501BF054.5050803@wwwdotorg.org> (raw)
In-Reply-To: <1344001434.25906.5.camel@phoenix>
On 08/03/2012 07:43 AM, Axel Lin wrote:
> The implementation in devm_request_and_ioremap() already shows error message,
> so no need to show dev_err again if devm_request_and_ioremap() fails.
I don't have any issue with this patch, but a general comment:
It sure would be nice if there was some way to easily tell which
functions did already print an error message. In some drivers I've
written, I've made sure that every failure path prints an error message
so it's easy to track down failures. However, if some functions already
do this and some don't, only some call sites in the driver will have
error prints, so it'll look inconsistent, as if some error messages were
forgotten:-(
next prev parent reply other threads:[~2012-08-03 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 13:43 [PATCH] pwm: Remove a redundant error message when devm_request_and_ioremap fails Axel Lin
2012-08-03 15:37 ` Stephen Warren [this message]
2012-08-09 5:41 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501BF054.5050803@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=avinashphilip@ti.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox