From: David Ahern <dsahern@gmail.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: oops in pci_acs_path_enabled
Date: Fri, 03 Aug 2012 16:08:10 -0600 [thread overview]
Message-ID: <501C4BCA.1080804@gmail.com> (raw)
In-Reply-To: <1344030733.8003.43.camel@ul30vt>
On 8/3/12 3:52 PM, Alex Williamson wrote:
> Is this the chunk that's causing the oops?
Yes. And taking it out fixes passthrough as well.
David
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 7469b53..27d8c97 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4133,6 +4133,7 @@ static int intel_iommu_add_device(struct device *dev)
> PCI_DEVFN(PCI_SLOT(dma_pdev->devfn),
> 0)));
>
> +#if 0
> while (!pci_is_root_bus(dma_pdev->bus)) {
> if (pci_acs_path_enabled(dma_pdev->bus->self,
> NULL, REQ_ACS_FLAGS))
> @@ -4140,6 +4141,7 @@ static int intel_iommu_add_device(struct device *dev)
>
> swap_pci_ref(&dma_pdev, pci_dev_get(dma_pdev->bus->self));
> }
> +#endif
>
> group = iommu_group_get(&dma_pdev->dev);
> pci_dev_put(dma_pdev);
>
>
next prev parent reply other threads:[~2012-08-03 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 17:39 oops in pci_acs_path_enabled David Ahern
2012-08-03 20:21 ` Alex Williamson
2012-08-03 21:12 ` David Ahern
2012-08-03 21:52 ` Alex Williamson
2012-08-03 22:08 ` David Ahern [this message]
2012-08-04 1:41 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501C4BCA.1080804@gmail.com \
--to=dsahern@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox