From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753948Ab2HDUSv (ORCPT ); Sat, 4 Aug 2012 16:18:51 -0400 Received: from relay03ant.iops.be ([212.53.5.218]:48231 "EHLO relay03ant.iops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099Ab2HDUSs (ORCPT ); Sat, 4 Aug 2012 16:18:48 -0400 Message-ID: <501D83A1.7040900@acm.org> Date: Sat, 04 Aug 2012 20:18:41 +0000 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Mike Christie CC: Chanho Min , James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Tejun Heo Subject: Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue References: <501CE4E5.20604@acm.org> <501D51D1.2010806@cs.wisc.edu> In-Reply-To: <501D51D1.2010806@cs.wisc.edu> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/12 16:46, Mike Christie wrote: > I think we have to have scsi-ml do a get_device when a sdev is added to > the starved entry and then do a put_device when it is removed (must do > these under the host lock for the starved entry case too). I am not sure > if that is just a hack/papering-over of the problem and there are more > issues like this. That would result in a more complex patch than the patch at the start of this thread, isn't it ? Also, IMHO it would help to document which functions in the scsi-ml are called with an sdev reference and which ones not. That would make the scsi-ml code easier to verify for issues like the one reported at the start of this thread. Bart.