From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Patrice Chotard <patrice.chotard@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pinctrl/nomadik: add ASIC DB8450 pinctrl driver
Date: Tue, 07 Aug 2012 14:26:18 -0600 [thread overview]
Message-ID: <502179EA.30301@wwwdotorg.org> (raw)
In-Reply-To: <1344341538-32223-1-git-send-email-linus.walleij@stericsson.com>
On 08/07/2012 06:12 AM, Linus Walleij wrote:
> From: Patrice Chotard <patrice.chotard@stericsson.com>
>
> This implements a subdriver for the DB8540 ASIC for the
> Nomadik pin controller.
> diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
> @@ -1722,6 +1722,8 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev)
> /* Poke in other ASIC variants here */
> if (version == PINCTRL_NMK_DB8500)
> nmk_pinctrl_db8500_init(&npct->soc);
> + if (platid->driver_data == PINCTRL_NMK_DB8540)
> + nmk_pinctrl_db8540_init(&npct->soc);
I'm surprised one of those checks "version" and the other
"platid->driver_data".
Aside from that, this looks fine.
next prev parent reply other threads:[~2012-08-07 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 12:12 [PATCH] pinctrl/nomadik: add ASIC DB8450 pinctrl driver Linus Walleij
2012-08-07 20:26 ` Stephen Warren [this message]
2012-08-08 8:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502179EA.30301@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@stericsson.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox