Re: [PATCH] x86/dt: use linear irq domain for ioapic(s).

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 08/08/2012 12:46 PM, Thierry Reding wrote:
>> +	id = irq_domain_add_linear(np, num,
>> +			&ioapic_irq_domain_ops,
>> +			(void *)ioapic_num);
>
> This fits on two lines instead of three.

k

>> +				pr_err("Error creating mapping for the "
>> +						"remaining  irqs: %d\n", ret);
>
> There's an extra space between "remaining" and "irqs". Also other places
> use the spelling IRQ and IRQs respectively in strings, so it may be nice
> to stay consistent.

I see.

> Besides the above nitpicks:
>
> Reviewed-by: Thierry Reding<thierry.reding@avionic-design.de>
> Tested-by: Thierry Reding<thierry.reding@avionic-design.de>

Thanks for testing.

> On another note, I saw that you've used the "intel,ce4100" prefix in
> various places and I wonder if it would be useful to replace them with
> something more generic like "intel,hpet", "intel,lapic" and
> "intel,ioapic" respectively. The hardware that I use is based on an Atom
> N450 and works with the current code, so it really isn't ce4100-
> specific.

No. You do have a compatible entry. It first appeared on the ce4100
CPU. If it happens to also work on the n450 then it seems to be
compatible with that one. "This" is documented somewhere…
Usually you add 'compatible = "your cpu", "generic binding"' in case
you need a fixup / errata whatever for "your cpu". Even if you compare
all hpets from Intel there is the one or other difference / errata.

> Thierry

Sebastian