Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

Arun Sharma
2012-08-08T22:38:04Z

On 8/8/12 12:16 PM, Arun Sharma wrote:

> and therefore breaks the invariant period == period_self
> in the default mode (no sort inclusive).

hist_entry__decay() also needs an update to maintain the invariant.

--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -138,6 +138,7 @@ static void hist_entry__add_cpumode_period(struct
hist_entry *he,
static void hist_entry__decay(struct hist_entry *he)
{
he->period = (he->period * 7) / 8;
+ he->period_self = (he->period_self * 7) / 8;
he->nr_events = (he->nr_events * 7) / 8;
}

-Arun