From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [GIT PULL for 3.6-rc1] media updates part 2
Date: Thu, 09 Aug 2012 08:38:04 -0300 [thread overview]
Message-ID: <5023A11C.50502@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1208081526320.11542@chino.kir.corp.google.com>
Em 08-08-2012 19:28, David Rientjes escreveu:
> On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote:
>
>> [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver
>
> This one gives me a build warning if CONFIG_LEDS_CLASS is disabled:
>
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>
Could you please test the enclosed patch?
Thanks!
Mauro
-
[media] radio-shark: make sure LEDS_CLASS is selected
As reported by David:
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
Reported-by: Dadiv Rientjes <rientjes@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8090b87..be68ec2 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -60,6 +60,7 @@ config RADIO_MAXIRADIO
config RADIO_SHARK
tristate "Griffin radioSHARK USB radio receiver"
depends on USB && SND
+ select LEDS_CLASS
---help---
Choose Y here if you have this radio receiver.
@@ -77,6 +78,7 @@ config RADIO_SHARK
config RADIO_SHARK2
tristate "Griffin radioSHARK2 USB radio receiver"
depends on USB
+ select LEDS_CLASS
---help---
Choose Y here if you have this radio receiver.
next prev parent reply other threads:[~2012-08-09 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 15:15 [GIT PULL for 3.6-rc1] media updates part 2 Mauro Carvalho Chehab
2012-07-31 23:00 ` Mauro Carvalho Chehab
2012-08-08 22:28 ` David Rientjes
2012-08-09 11:38 ` Mauro Carvalho Chehab [this message]
2012-08-09 12:00 ` Hans de Goede
2012-08-09 12:38 ` Mauro Carvalho Chehab
2012-08-09 20:03 ` David Rientjes
2012-08-10 7:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5023A11C.50502@redhat.com \
--to=mchehab@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).