From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835Ab2HJGqM (ORCPT ); Fri, 10 Aug 2012 02:46:12 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:14107 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753889Ab2HJGqJ (ORCPT ); Fri, 10 Aug 2012 02:46:09 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6798"; a="221276353" Message-ID: <5024AE2D.5050506@codeaurora.org> Date: Thu, 09 Aug 2012 23:46:05 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: linux-arm-kernel@lists.infradead.org CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving References: <1343956994-27513-1-git-send-email-sboyd@codeaurora.org> In-Reply-To: <1343956994-27513-1-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/2012 6:23 PM, Stephen Boyd wrote: > During the p2v changes, the PHYS_OFFSET #define moved into a > !__ASSEMBLY__ section. This causes a XIP build to fail with > > arch/arm/kernel/head.o: In function 'stext': > arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET' > > Momentarily leave the #ifndef __ASSEMBLY__ section so we can > define PHYS_OFFSET for all compilation units. > > Signed-off-by: Stephen Boyd > --- > > I don't know if it's worth stable, seems that nobody has compiled XIP for > a year (back to 2.6.39 days?). Is this approach acceptable? Shall I put this in the patch tracker? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.