From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] NULL dereference BUG in sch56xx_init()
Date: Fri, 10 Aug 2012 10:35:59 +0200 [thread overview]
Message-ID: <5024C7EF.7090408@redhat.com> (raw)
In-Reply-To: <20120809144239.GA6604@roeck-us.net>
Hi,
On 08/09/2012 04:42 PM, Guenter Roeck wrote:
> On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote:
>> Hi Guenter,
>>
>> This commit triggered an oops which can be fixed by the attached diff.
>> Should it be folded into the original one (preferable for me), or be
>> resent as a standalone patch?
>>
> I folded it into the original commit.
>
> Thanks a lot for the test and feedback!
Fengguang, good catch, thanks!
Guenter, 2 remarks:
1) The changing of the type of the address parameter of sch56xx_device_add is
not necessary
2) A similar change is needed for the f71882fg, there the type of the address
variable in f71882fg_init() needs to be changed to int too.
Regards,
Hans
next prev parent reply other threads:[~2012-08-10 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 12:55 NULL dereference BUG in sch56xx_init() Fengguang Wu
2012-08-09 14:42 ` Guenter Roeck
2012-08-10 8:35 ` Hans de Goede [this message]
2012-08-10 15:48 ` [lm-sensors] " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5024C7EF.7090408@redhat.com \
--to=hdegoede@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).