From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751026AbcFVXeT (ORCPT ); Wed, 22 Jun 2016 19:34:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41588 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750721AbcFVXeR (ORCPT ); Wed, 22 Jun 2016 19:34:17 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Thiago Jung Bauermann To: Dave Young Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. Date: Wed, 22 Jun 2016 20:34:10 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-87-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160622101801.GB7752@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <1466538521-31216-4-git-send-email-bauerman@linux.vnet.ibm.com> <20160622101801.GB7752@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062223-0020-0000-0000-00000217201F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062223-0021-0000-0000-00002FED5F87 Message-Id: <5025034.R6Ttz76WZM@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-22_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606220238 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > +/** > > + * kexec_locate_mem_hole - find free memory to load segment or use in > > purgatory + * @image: kexec image being updated. > > + * @size: Memory size. > > + * @align: Minimum alignment needed. > > + * @min_addr: Minimum starting address. > > + * @max_addr: Maximum end address. > > + * @top_down Find the highest free memory region? > > + * @addr On success, will have start address of the memory region > > found. > > + * > > + * Return: 0 on success, negative errno on error. > > + */ > > +int kexec_locate_mem_hole(struct kimage *image, unsigned long size, > > + unsigned long align, unsigned long min_addr, > > + unsigned long max_addr, bool top_down, > > + unsigned long *addr) > > +{ > > + int ret; > > + struct kexec_buf buf; > > + > > + memset(&buf, 0, sizeof(struct kexec_buf)); > > + buf.image = image; > > + > > + buf.memsz = size; > > + buf.buf_align = align; > > + buf.buf_min = min_addr; > > + buf.buf_max = max_addr; > > + buf.top_down = top_down; > > Since patch 2/9 moved kexec_buf from internal header file to kexec.h it > will be natural to passing a kexec_buf pointer intead of passing all > these arguments in kexec_locate_mem_hole. > > kbuf.mem can be used for addr. Ok. What about this version? -- []'s Thiago Jung Bauermann IBM Linux Technology Center Subject: [PATCH 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer. kexec_locate_mem_hole will be used by the PowerPC kexec_file_load implementation to find free memory for the purgatory stack. Signed-off-by: Thiago Jung Bauermann Cc: Eric Biederman Cc: Dave Young Cc: kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- include/linux/kexec.h | 12 +++++++++--- kernel/kexec_file.c | 25 ++++++++++++++++++++----- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 3d91bcfc180d..e8b099da47f5 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -147,9 +147,14 @@ struct kexec_file_ops { #endif }; -/* - * Keeps track of buffer parameters as provided by caller for requesting - * memory placement of buffer. +/** + * struct kexec_buf - parameters for finding a place for a buffer in memory + * @image: kexec image in which memory to search. + * @size: Memory size for the buffer. + * @align: Minimum alignment needed. + * @min_addr: Minimum starting address. + * @max_addr: Maximum end address. + * @top_down: Find the highest free memory region? */ struct kexec_buf { struct kimage *image; @@ -163,6 +168,7 @@ struct kexec_buf { int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf, int (*func)(u64, u64, void *)); +int kexec_locate_mem_hole(struct kexec_buf *kbuf); #endif /* CONFIG_KEXEC_FILE */ struct kimage { diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index b1f1f6402518..445d66add8ca 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -449,6 +449,23 @@ int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf, return walk_system_ram_res(0, ULONG_MAX, kbuf, func); } +/** + * kexec_locate_mem_hole - find free memory to load segment or use in purgatory + * @kbuf: Parameters for the memory search. + * + * On success, kbuf->mem will have the start address of the memory region found. + * + * Return: 0 on success, negative errno on error. + */ +int kexec_locate_mem_hole(struct kexec_buf *kbuf) +{ + int ret; + + ret = arch_kexec_walk_mem(kbuf, locate_mem_hole_callback); + + return ret == 1 ? 0 : -EADDRNOTAVAIL; +} + /* * Helper function for placing a buffer in a kexec segment. This assumes * that kexec_mutex is held. @@ -493,11 +510,9 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz, kbuf->top_down = top_down; /* Walk the RAM ranges and allocate a suitable range for the buffer */ - ret = arch_kexec_walk_mem(kbuf, locate_mem_hole_callback); - if (ret != 1) { - /* A suitable memory range could not be found for buffer */ - return -EADDRNOTAVAIL; - } + ret = kexec_locate_mem_hole(kbuf); + if (ret) + return ret; /* Found a suitable memory range */ ksegment = &image->segment[image->nr_segments]; -- 1.9.1