public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Patrice Chotard <patrice.chotard@stericsson.com>
Subject: Re: [PATCH 2/2] ARM: nomadik: configure Nomadik for pin control
Date: Fri, 10 Aug 2012 17:18:33 -0600	[thread overview]
Message-ID: <502596C9.4010900@wwwdotorg.org> (raw)
In-Reply-To: <1344552220-995-1-git-send-email-linus.walleij@linaro.org>

On 08/09/2012 04:43 PM, Linus Walleij wrote:
> This converts the Nomadik to using pin control using the
> driver for the STN8815 ASIC.

> diff --git a/arch/arm/mach-nomadik/cpu-8815.c b/arch/arm/mach-nomadik/cpu-8815.c

> +static inline void
> +cpu8815_add_pinctrl(struct device *parent, const char *name)
> +{
> +	struct platform_device_info pdevinfo = {
> +		.parent = parent,
> +		.name = name,
> +		.id = -1,
> +	};
> +
> +	platform_device_register_full(&pdevinfo);
> +}

Out of curiosity, why platform_device_register_full() not
platform_device_register() here?

Otherwise,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>


  reply	other threads:[~2012-08-10 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 22:43 [PATCH 2/2] ARM: nomadik: configure Nomadik for pin control Linus Walleij
2012-08-10 23:18 ` Stephen Warren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-06-08  9:07 Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502596C9.4010900@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrice.chotard@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox