From: Denis <yefremov.denis@gmail.com>
To: balbi@ti.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: otg: twl4030-usb: spin_unlock_irq in interrupt handler
Date: Sat, 11 Aug 2012 15:31:19 +0400 [thread overview]
Message-ID: <50264287.9000900@gmail.com> (raw)
In-Reply-To: <20120809093706.GM12174@arwen.pp.htv.fi>
On 09.08.2012 13:37, Felipe Balbi wrote:
> Hi,
>
> I have pushed a patch which I think solves this issue. Can you test ?
Hi,
my patch is unneeded since this is a threaded interrupt handler. And it
runs with
interrupt line masked globally on the controller(because of IRQF_ONESHOT).
And I think that "sti" instruction can't reenable this line because it
is cpu related.
The point was that if "local_irq_enable" is called in primary irq
handler or in
request_irq handler you reenables (maybe accidentally) interrupts on the
cpu.
Because after patch https://lkml.org/lkml/2010/3/25/434 these handlers
runs with
interrupts disabled.
Some time ago our static tool didn't make any difference between
ordinary and
threaded interrupts handlers. At that time I didn't know it and didn't
check the
code enough. So it was a false positive.
prev parent reply other threads:[~2012-08-11 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 7:40 [PATCH] usb: otg: twl4030-usb: spin_unlock_irq in interrupt handler Denis Efremov
2012-08-09 9:37 ` Felipe Balbi
2012-08-11 11:31 ` Denis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50264287.9000900@gmail.com \
--to=yefremov.denis@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox