From: John Fastabend <john.r.fastabend@intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic
Date: Sun, 12 Aug 2012 23:23:59 -0700 [thread overview]
Message-ID: <50289D7F.3070402@intel.com> (raw)
In-Reply-To: <502896C5.7080303@intel.com>
> OK clearly I screwed it up thanks for reviewing Al. How about this.
>
> fdt = files_fdtable(files);
> for (fd = 0; fd < fdt->max_fds; fd++) {
> struct socket *sock;
> int err = 0;
>
> sock = sockfd_lookup(fd, &err);
> if (!sock) {
typo ^^^^^^
if (sock) {
to be honest I can't see why I didn't use sockfd_lookup in the first
place...
next prev parent reply other threads:[~2012-08-13 6:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 1:53 [flame^Wreview] net: netprio_cgroup: rework update socket logic Al Viro
2012-08-13 2:30 ` Al Viro
2012-08-13 5:55 ` John Fastabend
2012-08-13 6:23 ` John Fastabend [this message]
2012-08-13 12:18 ` Al Viro
2012-08-13 16:58 ` John Fastabend
2012-08-13 17:01 ` Al Viro
2012-08-13 17:31 ` John Fastabend
2012-08-13 9:08 ` Joe Perches
2012-08-13 11:22 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50289D7F.3070402@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).