* "regulator: Enable supply regulator if child rail is enabled" broken?
@ 2012-08-14 8:38 Rabin Vincent
2012-08-14 8:51 ` Laxman Dewangan
0 siblings, 1 reply; 4+ messages in thread
From: Rabin Vincent @ 2012-08-14 8:38 UTC (permalink / raw)
To: ldewangan, Mark Brown, lrg; +Cc: LKML
It appears that this patch causes incorrect reference counting on supply
regulators if the child regulator is enabled with for example boot_on=true:
commit b2296bd43e781976743354c668a356b0df98e1da
Author: Laxman Dewangan <ldewangan@nvidia.com>
Date: Mon Jan 2 13:08:45 2012 +0530
regulator: Enable supply regulator if child rail is enabled.
If a regulator is enabled at boot (by constraints), then this patch calls
regulator_enable() on the supply regulator, leading to a use_count increase on
the supply. However, this patch adds no code to perform the corresponding
regulator_disable(), leaving the supply regulator on even when all consumers
have disabled it.
AFAICS, this patch would have only worked for always_on regulators.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: "regulator: Enable supply regulator if child rail is enabled" broken?
2012-08-14 8:38 "regulator: Enable supply regulator if child rail is enabled" broken? Rabin Vincent
@ 2012-08-14 8:51 ` Laxman Dewangan
2012-08-14 9:15 ` Rabin Vincent
0 siblings, 1 reply; 4+ messages in thread
From: Laxman Dewangan @ 2012-08-14 8:51 UTC (permalink / raw)
To: Rabin Vincent; +Cc: Mark Brown, lrg@ti.com, LKML
On Tuesday 14 August 2012 02:08 PM, Rabin Vincent wrote:
> It appears that this patch causes incorrect reference counting on supply
> regulators if the child regulator is enabled with for example boot_on=true:
>
> commit b2296bd43e781976743354c668a356b0df98e1da
> Author: Laxman Dewangan<ldewangan@nvidia.com>
> Date: Mon Jan 2 13:08:45 2012 +0530
>
> regulator: Enable supply regulator if child rail is enabled.
>
> If a regulator is enabled at boot (by constraints), then this patch calls
> regulator_enable() on the supply regulator, leading to a use_count increase on
> the supply. However, this patch adds no code to perform the corresponding
> regulator_disable(), leaving the supply regulator on even when all consumers
> have disabled it.
>
> AFAICS, this patch would have only worked for always_on regulators.
Yaah, It is missing the regulator_disable() in regulator_init_complete()
for some cases.
Please let me know if I need to send patch for fixing this issue.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: "regulator: Enable supply regulator if child rail is enabled" broken?
2012-08-14 8:51 ` Laxman Dewangan
@ 2012-08-14 9:15 ` Rabin Vincent
2012-08-14 10:11 ` Laxman Dewangan
0 siblings, 1 reply; 4+ messages in thread
From: Rabin Vincent @ 2012-08-14 9:15 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: Mark Brown, lrg@ti.com, LKML
2012/8/14 Laxman Dewangan <ldewangan@nvidia.com>:
> Yaah, It is missing the regulator_disable() in regulator_init_complete() for
> some cases.
> Please let me know if I need to send patch for fixing this issue.
Yes, please do.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: "regulator: Enable supply regulator if child rail is enabled" broken?
2012-08-14 9:15 ` Rabin Vincent
@ 2012-08-14 10:11 ` Laxman Dewangan
0 siblings, 0 replies; 4+ messages in thread
From: Laxman Dewangan @ 2012-08-14 10:11 UTC (permalink / raw)
To: Rabin Vincent; +Cc: Mark Brown, lrg@ti.com, LKML
On Tuesday 14 August 2012 02:45 PM, Rabin Vincent wrote:
> 2012/8/14 Laxman Dewangan<ldewangan@nvidia.com>:
>> Yaah, It is missing the regulator_disable() in regulator_init_complete() for
>> some cases.
>> Please let me know if I need to send patch for fixing this issue.
> Yes, please do.
I sent a patch. Please confirm whether this resolves the issue addressed
by you or not.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-14 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 8:38 "regulator: Enable supply regulator if child rail is enabled" broken? Rabin Vincent
2012-08-14 8:51 ` Laxman Dewangan
2012-08-14 9:15 ` Rabin Vincent
2012-08-14 10:11 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).