From: "Wouter M. Koolen" <W.M.Koolen-Wijkstra@cwi.nl>
To: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
acme@ghostprotocols.net
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [perf] make clean problematic bashism
Date: Wed, 15 Aug 2012 11:52:14 +0200 [thread overview]
Message-ID: <502B714E.4010700@cwi.nl> (raw)
Dear perf maintainers,
I attempted to compile perf 3.5.1 without worrying about installing
dependencies first. The resulting error messages were quite helpful, and
led me to install a bunch of development libraries and flex.
Unfortunately, after installing flex the build still failed, even after
make clean.
The reason for this was a bunch of generated empty flex files in util/
that were not removed by make clean. They are intended to be erased,
since the Makefile executes
rm -f util/*-{bison,flex}*
however, this command does not remove the files. I guess because {,}
alternatives are only special in bash but the makefile is run with some
other shell?
I got perf to compile now, but thought you would be interested to know
about this little problem.
With kind regards,
Wouter Koolen
PS: as a side note: GNU make has the .DELETE_ON_ERROR: special target,
which removes the target file when its generating command fails. This
would have prevented my problem and sounds like a good idea in general.
Maybe perf could make use of this feature when on GNU make?
next reply other threads:[~2012-08-15 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 9:52 Wouter M. Koolen [this message]
2012-08-15 10:26 ` [perf] make clean problematic bashism Peter Zijlstra
2012-08-15 10:39 ` Wouter M. Koolen
2012-08-15 13:12 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502B714E.4010700@cwi.nl \
--to=w.m.koolen-wijkstra@cwi.nl \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox