From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
gleb@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, jan.kiszka@siemens.com
Subject: Re: [PATCH v7 2/2] kvm: KVM_EOIFD, an eventfd for EOIs
Date: Wed, 15 Aug 2012 16:09:46 +0300 [thread overview]
Message-ID: <502B9F9A.6020901@redhat.com> (raw)
In-Reply-To: <1344986787.4683.370.camel@ul30vt.home>
On 08/15/2012 02:26 AM, Alex Williamson wrote:
>
> Yes, I understand. It's simple, it's also very specific to this
> problem, and doesn't address generic ack notification. All of which
> I've noted before and I continue to note that v8 offers simplifications
> while retaining flexibility. Least amount of code doesn't really buy us
> much if we end up needing to invent new interfaces down the road because
> we've created such a specific solution here. Thanks,
>
One side of the coin is trying to create one generic interface instead
of multiple specific interfaces. The other side is that by providing a
generic interface, you sometimes expose internal implementation details,
or you constrain future development in order to preserve that interface.
If the generic interface is not actually exploited, you get pain for no
gain.
This tradeoff is different for every feature. Right now I'm leaning
towards specialized interfaces here, because we expose quite a lot of
low-level detail. However I'll review v8 soon and see.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-15 13:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:43 [PATCH v7 0/2] kvm: level irqfd and new eoifd Alex Williamson
2012-07-24 20:43 ` [PATCH v7 1/2] kvm: Extend irqfd to support level interrupts Alex Williamson
2012-07-29 15:01 ` Michael S. Tsirkin
2012-07-30 16:06 ` Alex Williamson
2012-07-24 20:43 ` [PATCH v7 2/2] kvm: KVM_EOIFD, an eventfd for EOIs Alex Williamson
2012-07-29 14:54 ` Michael S. Tsirkin
2012-07-30 16:22 ` Alex Williamson
2012-07-31 0:01 ` Michael S. Tsirkin
2012-07-31 0:26 ` Alex Williamson
2012-07-31 0:36 ` Michael S. Tsirkin
2012-07-31 1:12 ` Alex Williamson
2012-08-01 19:06 ` Alex Williamson
2012-08-12 7:49 ` Michael S. Tsirkin
2012-08-13 16:48 ` Alex Williamson
2012-08-13 16:59 ` Michael S. Tsirkin
2012-08-13 18:17 ` Alex Williamson
2012-08-13 19:50 ` Michael S. Tsirkin
2012-08-13 20:48 ` Alex Williamson
2012-08-13 21:50 ` Michael S. Tsirkin
2012-08-13 22:22 ` Alex Williamson
2012-08-13 22:52 ` Michael S. Tsirkin
2012-08-14 10:10 ` Gleb Natapov
2012-08-14 10:13 ` Gleb Natapov
2012-08-02 8:42 ` Michael S. Tsirkin
2012-08-06 10:17 ` Avi Kivity
2012-08-06 10:38 ` Avi Kivity
2012-08-06 10:40 ` Avi Kivity
2012-08-09 19:26 ` Alex Williamson
2012-08-12 8:36 ` Avi Kivity
2012-08-13 21:34 ` Alex Williamson
2012-08-13 22:06 ` Michael S. Tsirkin
2012-08-13 22:41 ` Alex Williamson
2012-08-13 23:00 ` Michael S. Tsirkin
2012-08-14 3:09 ` Alex Williamson
2012-08-14 8:35 ` Michael S. Tsirkin
2012-08-14 21:28 ` Alex Williamson
2012-08-12 9:33 ` Michael S. Tsirkin
2012-08-13 21:23 ` Alex Williamson
2012-08-13 22:00 ` Michael S. Tsirkin
2012-08-14 12:35 ` Avi Kivity
2012-08-14 14:50 ` Michael S. Tsirkin
2012-08-14 22:01 ` Alex Williamson
2012-08-14 23:04 ` Michael S. Tsirkin
2012-08-14 23:26 ` Alex Williamson
2012-08-15 13:09 ` Avi Kivity [this message]
2012-08-12 7:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502B9F9A.6020901@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).