From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756306Ab2HPITU (ORCPT ); Thu, 16 Aug 2012 04:19:20 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:42387 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756116Ab2HPITR (ORCPT ); Thu, 16 Aug 2012 04:19:17 -0400 Message-ID: <502CACFF.3000105@metafoo.de> Date: Thu, 16 Aug 2012 10:19:11 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120613 Icedove/3.0.11 MIME-Version: 1.0 To: "Kim, Milo" CC: Jonathan Cameron , "jic23@cam.ac.uk" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH 1/3] iio: add iio_read_channel_offset() consumer api References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2012 09:39 AM, Kim, Milo wrote: > This allows the iio consumer to get the offset of the channel. > The value of offset can be used when calculating the result such > as 'result = raw * scale + offset'. result = (raw + offset) * scale Otherwise it looks good, except for: > +/** > + * iio_read_channel_offset() - read offset from a given channel > + * @channel: The channel being queried. > + * @val: Offset Value read back. > + * > + * Note offset can be used in the consumer when calculating the result > + * such as 'result = raw * scale + offset'. > + */ The documentation should go in the c file. > +int iio_read_channel_offset(struct iio_channel *chan, int *val); > #endif