From: Dave Jiang <dave.jiang@intel.com>
To: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
vinicius.gomes@intel.com, fenghuay@nvidia.com, vkoul@kernel.org
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore
Date: Wed, 21 May 2025 16:13:49 -0700 [thread overview]
Message-ID: <502b82d9-7343-46b2-a820-c7f47f12de10@intel.com> (raw)
In-Reply-To: <20250521231331.889204-1-anil.s.keshavamurthy@intel.com>
On 5/21/25 4:13 PM, Anil S Keshavamurthy wrote:
> Deletes the second initialization as the value stored to 'dev' during
> its initialization (struct device *dev = &idxd->pdev->dev;) is
> sufficient.
>
> ../drivers/dma/idxd/init.c:988:17: warning: Value stored to 'dev' during
> its initialization is never read [deadcode.DeadStores]
> 988 | struct device *dev = &idxd->pdev->dev;
> | ^~~ ~~~~~~~~~~~~~~~~
>
> Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index fca1d2924999..b7664136fc67 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -989,7 +989,6 @@ static void idxd_reset_prepare(struct pci_dev *pdev)
> const char *idxd_name;
> int rc;
>
> - dev = &idxd->pdev->dev;
> idxd_name = dev_name(idxd_confdev(idxd));
>
> struct idxd_saved_states *idxd_saved __free(kfree) =
next prev parent reply other threads:[~2025-05-21 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 23:13 [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore Anil S Keshavamurthy
2025-05-21 23:13 ` Dave Jiang [this message]
2025-06-26 22:48 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502b82d9-7343-46b2-a820-c7f47f12de10@intel.com \
--to=dave.jiang@intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghuay@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox