Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

Felipe Balbi
2012-08-17T10:56:28Z

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Fri, Aug 17, 2012 at 11:42:15AM +0200, Sebastian Andrzej Siewior wrote:
> On 08/17/2012 11:10 AM, Roland Stigge wrote:
> >Also, since this device is a single controller in the LPC32xx SoC, I
> >would keep it until some other silicon uses several of this IP core
> >(which I doubt), at which point we would probably still keep the (global
> >static) controller and memcpy it to a dynamically allocated struct.
> >
> >Sounds reasonable?
>
> Yes it does.
>
> Some minor things:
> - please use to_udc() in start then
> - would it make sense to use platform_get_drvdata() in
> lpc32xx_udc_shutdown() ?
> - could you please remove struct usb_endpoint_descriptor from struct
> lpc32xx_ep? It has been removed a while back from other drivers.
>
> Your proc_udc_show() makes me sad. Felipe, didn't we want something
> like this in udc-core?

Yes we do, though not a single file with a bunch of values. We want one
value per file as it should be.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]