linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Stephen Warren <swarren@nvidia.com>,
	"olof@lixom.net" <olof@lixom.net>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators
Date: Mon, 20 Aug 2012 22:52:10 +0530	[thread overview]
Message-ID: <50327242.80103@nvidia.com> (raw)
In-Reply-To: <502EA1AC.4090205@wwwdotorg.org>

On Saturday 18 August 2012 01:25 AM, Stephen Warren wrote:
> On 08/17/2012 01:27 PM, Stephen Warren wrote:
>> On 08/17/2012 12:59 AM, Laxman Dewangan wrote:
>>> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a
>>> couple of fixed GPIO-controlled regulators too.
>>>
>>> Based on Ventana regulator patch by Stephen Warren<swarren@nvidia.com>
>>> and converted to Harmony.
>> Thanks, applied to Tegra's for-3.7/dt branch.
> Oh hang on, this adds regulators to DT, but doesn't do anything to
> remove the board-file registration of Harmony's regulators from
> board-dt-tegra20.c, which end up conflicting, and preventing the PCIe
> driver from being registered.
>
> So, this patch really wants to remove the legacy code to, but doing so
> will be problematic; to avoid runtime git bisect failures, we'd need to
> merge the regulator tree in first, or wait until next kernel release or
> something... Thoughts?

Why not just remove the regulator registration from board files along 
with the dt entry (in one patch). That will resolve the issue of bisect.


  reply	other threads:[~2012-08-20 17:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17  6:59 [PATCH] ARM: dt: tegra: harmony: add regulators Laxman Dewangan
2012-08-17 19:27 ` Stephen Warren
2012-08-17 19:55   ` Stephen Warren
2012-08-20 17:22     ` Laxman Dewangan [this message]
2012-08-20 17:49       ` Stephen Warren
2012-08-20 17:54         ` Mark Brown
2012-08-20 18:08           ` Stephen Warren
2012-08-20 18:14             ` Mark Brown
2012-08-20 18:37               ` Stephen Warren
2012-08-22 19:07                 ` Mark Brown
2012-08-24 18:53                   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50327242.80103@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).