From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777Ab2HTSIu (ORCPT ); Mon, 20 Aug 2012 14:08:50 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:36966 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808Ab2HTSIt (ORCPT ); Mon, 20 Aug 2012 14:08:49 -0400 Message-ID: <50327D2D.6000509@wwwdotorg.org> Date: Mon, 20 Aug 2012 12:08:45 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: Laxman Dewangan , Stephen Warren , "olof@lixom.net" , "linux@arm.linux.org.uk" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Liam Girdwood Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators References: <1345186799-18229-1-git-send-email-ldewangan@nvidia.com> <502E9B09.3080800@wwwdotorg.org> <502EA1AC.4090205@wwwdotorg.org> <50327242.80103@nvidia.com> <50327897.5030601@wwwdotorg.org> <20120820175410.GI26991@opensource.wolfsonmicro.com> In-Reply-To: <20120820175410.GI26991@opensource.wolfsonmicro.com> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/20/2012 11:54 AM, Mark Brown wrote: > On Mon, Aug 20, 2012 at 11:49:11AM -0600, Stephen Warren wrote: > >> The problem there is that will prevent any regulators from being >> registered at all, until the patch is merged with the regulator >> tree. That will also prevent PCIe working on Harmony. Those both >> work right now, so that's a bisection breakage. > >> I suppose the solution here is to merge the regulator tree into >> the Tegra branch before the Harmony regulator patch. Mark, can we >> do that? > > I've no idea what you're talking about here, sorry. What are > "this" and "the patch"? Surely you can just add whatever DT > changes you need to add without the thing that uses the bindings? When booting Harmony using device tree, there's a special case that registers all the regulators using the remnants of the Harmony board file. Hence, regulators work right now even without the DT instantiating them. The patch in this thread adds all the required regulators to the DT file. However, it should also remove the special case so the regulators don't get registered twice, once from the board file and once from DT. However, doing that would prevent regulators getting registered at all, since v3.6-rc* don't have all the required (TPS6586x) regulator (driver) patches to get the regulators instantiated from DT. Everything will only work in linux-next or sometime during the 3.7 merge window. Hence, git bisect would be broken. One solution to this is to bring the regulator tree into the Tegra tree as a dependency, and then apply a patch which adds the regulators to DT, and removes the special case from the board file. I'm asking for your OK to do that.